Drop dependency on pyparsing. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code which required pyparsing was dropped in ament#75.
dirk-thomas
approved these changes
Jun 13, 2018
|
Before I merge, can I confirm that this change is 🆒 to merge with no CI since non-source dependencies don't affect CI builds? |
I wouldn't say this can't affect the CI build. But I am fine without CI since this dependency is clearly not required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code which required pyparsing was dropped in #75.
Incidentally it doesn't appear that the pyparsing dependency was ever added to setup.py. In general we want to keep setup.py and package.xml dependencies in sync right?